PR #16841: Delete FP8 Scaling Factors in GEMM Rewriter #17731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_679766659
branch
from
f0b64bb
to
4271e44
Compare
Imported from GitHub PR #16841 Removes the scaling factors of C and D (matrix bias and result) from FP8 Custom Calls created in the GEMM rewriter when their data types are not FP8. See #15795. Copybara import of the project: -- fd9750f by Philipp Hack <[email protected]>: Removes superfluous FP8 scaling factors in GEMM rewriter. Merging this change closes #16841 COPYBARA_INTEGRATE_REVIEW=#16841 from philipphack:u_fp8_scales_xla fd9750f PiperOrigin-RevId: 679784586
copybara-service
bot
force-pushed
the
test_679766659
branch
from
4271e44
to
3c5c920
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #16841: Delete FP8 Scaling Factors in GEMM Rewriter
Imported from GitHub PR #16841
Removes the scaling factors of C and D (matrix bias and result) from FP8 Custom Calls created in the GEMM rewriter when their data types are not FP8. See #15795.
Copybara import of the project:
--
fd9750f by Philipp Hack [email protected]:
Removes superfluous FP8 scaling factors in GEMM rewriter.
Merging this change closes #16841
FUTURE_COPYBARA_INTEGRATE_REVIEW=#16841 from philipphack:u_fp8_scales_xla fd9750f